added some small code improvements #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turnerran
changed the title
jsumners
reviewed
Sep 2, 2023
jsumners
reviewed
Sep 2, 2023
Fdawgs
requested changes
Sep 3, 2023
gurgunday
reviewed
Sep 3, 2023
Co-authored-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com>
gurgunday
reviewed
Sep 3, 2023
Co-authored-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com>
|
CI seems to be failing. |
|
Please rebase on top of master. |
Hey @mcollina , I'm up to date with master |
|
I've updated it for you. |
Uzlopak
reviewed
Sep 5, 2023
Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
jsumners
approved these changes
Sep 6, 2023
Uzlopak
reviewed
Sep 6, 2023
Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
|
@Fdawgs PTAL |
gurgunday
reviewed
Sep 6, 2023
Co-authored-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com>
Fdawgs
approved these changes
Sep 6, 2023
|
Btw. I am old school and never benchmarked the benefit of || vs. ??. Keep in mind, that || can be used in branchless programming. Personally I never checked how ?? is implemented in nodejs. So should be in cases like calling another function, |
I see, I thought it'd be a clear case since |
renovate bot
referenced
this pull request
in redwoodjs/redwood
Sep 16, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/static](https://togithub.com/fastify/fastify-static) | [`6.11.0` -> `6.11.1`](https://renovatebot.com/diffs/npm/@fastify%2fstatic/6.11.0/6.11.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-static (@​fastify/static)</summary> ### [`v6.11.1`](https://togithub.com/fastify/fastify-static/releases/tag/v6.11.1) [Compare Source](https://togithub.com/fastify/fastify-static/compare/v6.11.0...v6.11.1) ##### What's Changed - Remove test/content-type/sample.jpg.br by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify-static/pull/400](https://togithub.com/fastify/fastify-static/pull/400) - build(deps-dev): bump tsd from 0.28.1 to 0.29.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-static/pull/401](https://togithub.com/fastify/fastify-static/pull/401) - added some small code improvements by [@​turnerran](https://togithub.com/turnerran) in [https://github.com/fastify/fastify-static/pull/399](https://togithub.com/fastify/fastify-static/pull/399) - (more) small performance/clarity improvements by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-static/pull/405](https://togithub.com/fastify/fastify-static/pull/405) - perf: use `node:` prefix to bypass require.cache call for builtins by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-static/pull/407](https://togithub.com/fastify/fastify-static/pull/407) - use native stream by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-static/pull/408](https://togithub.com/fastify/fastify-static/pull/408) - Fix request route config deprecation warnings by [@​TTPO100AJIEX](https://togithub.com/TTPO100AJIEX) in [https://github.com/fastify/fastify-static/pull/409](https://togithub.com/fastify/fastify-static/pull/409) ##### New Contributors - [@​turnerran](https://togithub.com/turnerran) made their first contribution in [https://github.com/fastify/fastify-static/pull/399](https://togithub.com/fastify/fastify-static/pull/399) - [@​TTPO100AJIEX](https://togithub.com/TTPO100AJIEX) made their first contribution in [https://github.com/fastify/fastify-static/pull/409](https://togithub.com/fastify/fastify-static/pull/409) **Full Changelog**: fastify/fastify-static@v6.11.0...v6.11.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtoar
referenced
this pull request
in redwoodjs/redwood
Sep 16, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/static](https://togithub.com/fastify/fastify-static) | [`6.11.0` -> `6.11.1`](https://renovatebot.com/diffs/npm/@fastify%2fstatic/6.11.0/6.11.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-static (@​fastify/static)</summary> ### [`v6.11.1`](https://togithub.com/fastify/fastify-static/releases/tag/v6.11.1) [Compare Source](https://togithub.com/fastify/fastify-static/compare/v6.11.0...v6.11.1) ##### What's Changed - Remove test/content-type/sample.jpg.br by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify-static/pull/400](https://togithub.com/fastify/fastify-static/pull/400) - build(deps-dev): bump tsd from 0.28.1 to 0.29.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-static/pull/401](https://togithub.com/fastify/fastify-static/pull/401) - added some small code improvements by [@​turnerran](https://togithub.com/turnerran) in [https://github.com/fastify/fastify-static/pull/399](https://togithub.com/fastify/fastify-static/pull/399) - (more) small performance/clarity improvements by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-static/pull/405](https://togithub.com/fastify/fastify-static/pull/405) - perf: use `node:` prefix to bypass require.cache call for builtins by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-static/pull/407](https://togithub.com/fastify/fastify-static/pull/407) - use native stream by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-static/pull/408](https://togithub.com/fastify/fastify-static/pull/408) - Fix request route config deprecation warnings by [@​TTPO100AJIEX](https://togithub.com/TTPO100AJIEX) in [https://github.com/fastify/fastify-static/pull/409](https://togithub.com/fastify/fastify-static/pull/409) ##### New Contributors - [@​turnerran](https://togithub.com/turnerran) made their first contribution in [https://github.com/fastify/fastify-static/pull/399](https://togithub.com/fastify/fastify-static/pull/399) - [@​TTPO100AJIEX](https://togithub.com/TTPO100AJIEX) made their first contribution in [https://github.com/fastify/fastify-static/pull/409](https://togithub.com/fastify/fastify-static/pull/409) **Full Changelog**: fastify/fastify-static@v6.11.0...v6.11.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in specfy/specfy
Dec 4, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/static](https://togithub.com/fastify/fastify-static) | [`6.10.2` -> `6.12.0`](https://renovatebot.com/diffs/npm/@fastify%2fstatic/6.10.2/6.12.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-static (@​fastify/static)</summary> ### [`v6.12.0`](https://togithub.com/fastify/fastify-static/releases/tag/v6.12.0) [Compare Source](https://togithub.com/fastify/fastify-static/compare/v6.11.2...v6.12.0) #### What's Changed - fix eslint by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-static/pull/415](https://togithub.com/fastify/fastify-static/pull/415) - refactor: add `u` unicode flag to regex by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-static/pull/418](https://togithub.com/fastify/fastify-static/pull/418) - refactor: remove unused bindings by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-static/pull/417](https://togithub.com/fastify/fastify-static/pull/417) - perf(index): check set size over converting to array to check length by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-static/pull/416](https://togithub.com/fastify/fastify-static/pull/416) - chore(package): explicitly declare js module type by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-static/pull/419](https://togithub.com/fastify/fastify-static/pull/419) - test: replace `typeof` undefined check by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-static/pull/420](https://togithub.com/fastify/fastify-static/pull/420) **Full Changelog**: fastify/fastify-static@v6.11.2...v6.12.0 ### [`v6.11.2`](https://togithub.com/fastify/fastify-static/releases/tag/v6.11.2) [Compare Source](https://togithub.com/fastify/fastify-static/compare/v6.11.1...v6.11.2) #### What's Changed - fix: allow fallback to fastify@2.22 route config by [@​climba03003](https://togithub.com/climba03003) in [https://github.com/fastify/fastify-static/pull/410](https://togithub.com/fastify/fastify-static/pull/410) **Full Changelog**: fastify/fastify-static@v6.11.1...v6.11.2 ### [`v6.11.1`](https://togithub.com/fastify/fastify-static/releases/tag/v6.11.1) [Compare Source](https://togithub.com/fastify/fastify-static/compare/v6.11.0...v6.11.1) #### What's Changed - Remove test/content-type/sample.jpg.br by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/fastify/fastify-static/pull/400](https://togithub.com/fastify/fastify-static/pull/400) - build(deps-dev): bump tsd from 0.28.1 to 0.29.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-static/pull/401](https://togithub.com/fastify/fastify-static/pull/401) - added some small code improvements by [@​turnerran](https://togithub.com/turnerran) in [https://github.com/fastify/fastify-static/pull/399](https://togithub.com/fastify/fastify-static/pull/399) - (more) small performance/clarity improvements by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-static/pull/405](https://togithub.com/fastify/fastify-static/pull/405) - perf: use `node:` prefix to bypass require.cache call for builtins by [@​Fdawgs](https://togithub.com/Fdawgs) in [https://github.com/fastify/fastify-static/pull/407](https://togithub.com/fastify/fastify-static/pull/407) - use native stream by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-static/pull/408](https://togithub.com/fastify/fastify-static/pull/408) - Fix request route config deprecation warnings by [@​TTPO100AJIEX](https://togithub.com/TTPO100AJIEX) in [https://github.com/fastify/fastify-static/pull/409](https://togithub.com/fastify/fastify-static/pull/409) #### New Contributors - [@​turnerran](https://togithub.com/turnerran) made their first contribution in [https://github.com/fastify/fastify-static/pull/399](https://togithub.com/fastify/fastify-static/pull/399) - [@​TTPO100AJIEX](https://togithub.com/TTPO100AJIEX) made their first contribution in [https://github.com/fastify/fastify-static/pull/409](https://togithub.com/fastify/fastify-static/pull/409) **Full Changelog**: fastify/fastify-static@v6.11.0...v6.11.1 ### [`v6.11.0`](https://togithub.com/fastify/fastify-static/releases/tag/v6.11.0) [Compare Source](https://togithub.com/fastify/fastify-static/compare/v6.10.2...v6.11.0) #### What's Changed - Update README with 404+wildcard behavior by [@​Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) in [https://github.com/fastify/fastify-static/pull/390](https://togithub.com/fastify/fastify-static/pull/390) - add tests for [#​234](https://togithub.com/fastify/fastify-static/issues/234) by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-static/pull/391](https://togithub.com/fastify/fastify-static/pull/391) - remove linting from the test script by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-static/pull/394](https://togithub.com/fastify/fastify-static/pull/394) - Remove redundant parameter by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-static/pull/395](https://togithub.com/fastify/fastify-static/pull/395) - build(deps-dev): bump [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) from 2.34.0 to 6.2.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/fastify/fastify-static/pull/397](https://togithub.com/fastify/fastify-static/pull/397) - add url type by [@​gurgunday](https://togithub.com/gurgunday) in [https://github.com/fastify/fastify-static/pull/398](https://togithub.com/fastify/fastify-static/pull/398) #### New Contributors - [@​Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) made their first contribution in [https://github.com/fastify/fastify-static/pull/390](https://togithub.com/fastify/fastify-static/pull/390) - [@​gurgunday](https://togithub.com/gurgunday) made their first contribution in [https://github.com/fastify/fastify-static/pull/391](https://togithub.com/fastify/fastify-static/pull/391) **Full Changelog**: fastify/fastify-static@v6.10.2...v6.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/specfy/specfy). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct